Added youtube link and 0.8em less of padding#3
Merged
Conversation
Owner
|
Sorry for the delay in getting to this PR. It looks good to me, and I will merge it shortly. If there is something else you want to tackle I think we can revisit this home page layout to something that scales better across screen sizes. We can probably use flexbox to have the icons slowly collapse into a single column, or we can set up some additional media queries to improve the snap points. Right now it's using some default styles from Bulma for nearly all of the styling, I am not sure Bulma has what we need out of the box so we'll have to write our own styles for this, but it's probably not too complicated (flex box should be able to accomplish basically all of our needs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the pspython YouTube channel link by adding a new element with link object on the home_links.json file.
Also tweaked the styling slightly on the assets/static/style.css by changing the .home-link-item padding from 2em to 1.2em. This keeps the horizontal line up on the main page from overflowing the viewport area.